fix(filesystem): unexpected error when saving file lead to crashing the app #2307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitarooman14
force-pushed
the
fix/crash_app_on_saving_corrupted_file
branch
from
f0fa867 to
17732a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you call the writefile plugin method from ionic with corrupted data or with not base64 data, it leads to a total crash of the app because the exception is not caught by the writefile method and it is only caught by the bridge.java that rethrow a runtimeException.
catch (Exception ex) { Logger.error("Serious error executing plugin", ex); throw new RuntimeException(ex); }